Fix StructuralSparseArray Clear function and add basic test #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh whoops.... This is a duplicate of #273, that's my bad. Keeping it open since mine adds a unit test, but the other code is slightly better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
StructuralSparseArrayis broken quite badly since theClear()method doesn't empty the whole array.Because of this, using Add and Remove in a reused CommandBuffer can occasionally corrupt the state of the world, by adding a component twice on an entity! The CommandBuffer needs to be recreated from scratch every time, because the
StructuralSparseArraydoes not clear correctly.This PR fixes the bug and adds a basic functionality test, testing operations against a control
HashSet. The test currently fails on master, but passes after this PR.I can't figure out how to reproduce the CommandBuffer bug for a unit test -- it only occurs in the wild after a very specific sequence of Add and Remove operations and playbacks, that I have yet to understand. But this fixes the root of the issue, regardless.