Stufe 5 - Subscritpion init migration to IG Publisher #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madduci
reviewed
Sep 24, 2025
| @@ -1,9 +1,17 @@ | |||
| FROM mcr.microsoft.com/devcontainers/base:alpine-3.18 | |||
| FROM mcr.microsoft.com/devcontainers/base:alpine-3.20 | |||
There was a problem hiding this comment.
here the version 3.22 could be used
| ENV CLOUD_SDK_VERSION=464.0.0 | ||
|
|
||
| # Google Cloud SDK herunterladen und installieren | ||
| RUN curl -O https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-cli-${CLOUD_SDK_VERSION}-linux-x86_64.tar.gz && \ |
There was a problem hiding this comment.
The official documentation has ditched the SDK version from the URL: https://cloud.google.com/sdk/docs/install#installation_instructions
| RUN apk add --no-cache nodejs npm | ||
|
|
||
| # Install Java (OpenJDK) | ||
| RUN apk add --no-cache openjdk11 |
| TARGET=5.0.0 | ||
| BUCKET_PATH=/ig/fhir/isik-basismodul | ||
| PREV="" # Leave empty to skip moving | ||
| BUCKET_NAME_DEV=gematik_gemspec_fhir_dev-0 |
There was a problem hiding this comment.
should this really be part of this git repository?
There was a problem hiding this comment.
The workflow for deployment on gemSpecPages (https://gemspec.gematik.de/docs/fhir/) relies on this file.
If you have a better idea how to solve it, let us have a talk with @cybernop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test für eine Migration von IG Subscription (momentan Simplifier IG) nach IG Publisher Version.
Für das Review:
IG kann über folgende Datei angesehen werden: publisher-guides\Subscription-IG\output\index.html
Vorgehensvorschlag:
zunächst nicht mergen, sondern auf das post-Processing Skript warten (und entsprechend fsh files wieder einfügen)
Als Dokumentation zum Vorgehen beachte folgendes: ISiK-Subscriptions-Migration-Strategie.md - https://github.com/gematik/spec-ISiK-Basismodul/pull/839/files#diff-839f525b9763cdbee8c57d2650a5f77dd3aaf2e12245f6efc194cd761a452c65