Use a simpler workaround for platform mixup issue #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `linux` and `linux-musl` platforms are both defined in the cross_platform array, then a rake task is defined for `lib/2.7/pg_ext.so` which links to `linux` instead of `linux-musl`. Disabling native tasks for the running ruby platform disables compiling `lib/2.7/pg_ext.so` completely. The mixed platform rake definition otherwise leads to a rake dependency chain like this: ``` rake aborted! Tasks: TOP => pkg/pg-1.6.0-x86_64-linux-musl.gem => lib/2.7/pg_ext.so => copy:pg_ext:x86_64-linux:2.7.8 => tmp/x86_64-linux/pg_ext/2.7.8/pg_ext.so => tmp/x86_64-linux/pg_ext/2.7.8/Makefile ```
larskanis
force-pushed
the
rc-workaround
branch
from
b9984b0 to
a76e8b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
linuxplatform comes first, then a rake task is defined forlib/2.7/pg_ext.sowhich links tolinuxinstead oflinux-musl. Defininglinux-muslfirst fixes this since the task is defined only once in:https://github.com/rake-compiler/rake-compiler/blob/ad13dd1ae1000e1ef91b95f3c7782ccca4c1c591/lib/rake/extensiontask.rb#L349
The mixed platform rake definition otherwise leads to a rake dependency chain like this: