fix: Updated bcrypt library to resolve compatibility issue (#1853) #1857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jonycoo
suggested changes
Jul 6, 2024
|
@jonycoo |
|
Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review? |
a3957273
reviewed
Feb 21, 2025
| @@ -102,7 +102,7 @@ | |||
| "argon2-browser": "^1.18.0", | |||
| "arrive": "^2.4.1", | |||
| "avsc": "^5.7.7", | |||
| "bcryptjs": "^2.4.3", | |||
| "bcrypt": "^5.1.1", | |||
There was a problem hiding this comment.
bcrypt, which requires node-gyp, supports a far fewer subset of Node versions than bcryptjs. Does the bcryptjs package also support the necessary functionality?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Updated bcrypt library to resolve compatibility issue (#1853)
Resolves: #1853