Skip to content

[1.0] Don't filter boolean values #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2017
Merged

[1.0] Don't filter boolean values #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/gatsby/lib/schema/__tests__/__snapshots__/data-tree-utils-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ Object {
"frontmatter___date": Object {
"field": "frontmatter.date",
},
"frontmatter___draft": Object {
"field": "frontmatter.draft",
},
"frontmatter___title": Object {
"field": "frontmatter.title",
},
Expand All @@ -42,6 +45,7 @@ Object {
"blue": 10010,
"circle": "happy",
"date": "2006-07-22T22:39:53.000Z",
"draft": false,
"title": "The world of slash and adventure",
},
"hair": 2,
Expand Down
1 change: 1 addition & 0 deletions packages/gatsby/lib/schema/__tests__/data-tree-utils-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ describe(`Gatsby data tree utils`, () => {
title: `The world of slash and adventure`,
blue: 10010,
circle: `happy`,
draft: false,
},
},
]
Expand Down
27 changes: 7 additions & 20 deletions packages/gatsby/lib/schema/data-tree-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,14 @@ const extractFieldExamples = (exports.extractFieldExamples = ({
selector,
deleteNodeFields = false,
}) => {
let examples = {}
_.each(nodes, node => {
let subNode
if (selector) {
subNode = _.get(node, selector)
} else {
subNode = node
}
let examples = nodes.reduce((mem, node) => {
let subNode = selector ? _.get(node, selector) : node

// Ignore undefined/null subnodes
if (subNode) {
const flattened = flatten(subNode, { maxDepth: 3, flatten: true })
// Remove non-truthy values
const truthyExamples = {}
_.each(flattened, (v, k) => {
if (v) {
truthyExamples[k] = v
}
})
examples = _.assign(examples, truthyExamples)
}
})
subNode = _.omitBy(flatten(subNode || {}), _.isNil)

return Object.assign({}, mem, subNode)
}, {})

examples = flatten.unflatten(examples, { safe: true })

Expand Down