Skip to content

Conversation

@koreyboone
Copy link
Contributor

No description provided.

@koreyboone
Copy link
Contributor Author

koreyboone commented Jun 18, 2018

The Container component within the CSS-In-JS section is created and imported but not use. It has inline styles that are also included in the about-css-modules.module.css
I remove the .container css from the module and replaced the root div in about-css-modules with Container.

@KyleAMathews KyleAMathews changed the base branch from v2 to master June 18, 2018 19:35
@KyleAMathews KyleAMathews changed the base branch from master to v2 June 18, 2018 19:35
@KyleAMathews
Copy link
Contributor

Thanks! This section is a bit confusing as we removed the css-in-js examples awhile ago and forgot to change the Container to use css modules. I'll merge this and then make that change.

@KyleAMathews KyleAMathews merged this pull request into gatsbyjs:v2 Jun 18, 2018
KyleAMathews pushed a commit that referenced this pull request Jun 18, 2018
#6000)

* [v2] Fix unused Container component references in part-two of tutorial

* Update index.md

* Update index.md
@koreyboone
Copy link
Contributor Author

koreyboone commented Jun 18, 2018

@KyleAMathews Yeah I also added a container.module.css to the components directory and included the margin: "3rem auto", maxWidth: 600 but wasn't sure if the inline style was on purpose or not so I didn't commit it. I'd be happy to submit another pull request for that... ?

@KyleAMathews
Copy link
Contributor

Ah great! Just put up my PR with the copy changes that were needed as well — would love your review! #6001

KyleAMathews pushed a commit that referenced this pull request Jun 21, 2018
#6000)

* [v2] Fix unused Container component references in part-two of tutorial

* Update index.md

* Update index.md
@jlengstorf
Copy link
Contributor

Hiya @kboone00! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants