Skip to content

Parse the port to a number if needed, further fixing #524 #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2016
Merged

Parse the port to a number if needed, further fixing #524 #526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f745b16
Parse the port to a number if needed, further fixing #524
bkonkle Oct 30, 2016
c6cb8f6
Fix the reassignment of program.port
bkonkle Oct 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/utils/develop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,15 +192,19 @@ function startServer (program) {
}

module.exports = (program) => {
detect(program.port, (err, _port) => {
const port = typeof program.port === 'string'
? parseInt(program.port, 10)
: program.port

detect(port, (err, _port) => {
if (err) {
console.error(err)
process.exit()
}

if (program.port !== _port) {
if (port !== _port) {
// eslint-disable-next-line max-len
const question = `Something is already running at port ${program.port} \nWould you like to run the app at another port instead? [Y/n] `
const question = `Something is already running at port ${port} \nWould you like to run the app at another port instead? [Y/n] `

return rlInterface.question(question, (answer) => {
if (answer.length === 0 || answer.match(/^yes|y$/i)) {
Expand Down