Wait for images to load before screenshotting #5028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Beckley <[email protected]>
|
Deploy preview for using-drupal ready! Built with commit 990b61f |
|
Deploy preview for gatsbygram ready! Built with commit 990b61f |
|
Sorry for previous comment - wrong browser tab :) |
pieh
approved these changes
Apr 18, 2018
|
Thanks @Thatotherperson! |
This was referenced Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like all images are loaded before the screenshot is taken, but there's a 0.5s transition fading from the low-res image to the high-res image. This PR makes the lambda wait until that fade has happened before taking a screenshot.
Signed-off-by: David Beckley [email protected]