feat!(gatsby-source-shopify): upgrade from Shopify API version 2022-04 to 2024-04 #39082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See breaking changes in: - https://shopify.dev/docs/api/release-notes/previous-versions/2022-07 - https://shopify.dev/docs/api/release-notes/previous-versions/2022-10 - https://shopify.dev/docs/api/release-notes/previous-versions/2023-01 - https://shopify.dev/docs/api/release-notes/previous-versions/2023-04
gatsbot
bot
added
the
status: triage needed
pieh
reviewed
Sep 10, 2024
packages/gatsby-source-shopify/src/type-builders/collection-type.ts
Outdated
Show resolved
Hide resolved
pieh
reviewed
Sep 10, 2024
packages/gatsby-source-shopify/__tests__/fixtures/bulk-results/collections.jsonl
Outdated
Show resolved
Hide resolved
pieh
added
topic: source-shopify
…opify-api-has-breaking-changes-and-thus-gatsby-source
…changes-and-thus-gatsby-source
pieh
force-pushed
the
serhalp/frp-1284-shopify-api-has-breaking-changes-and-thus-gatsby-source
branch
from
ab17f2e to
ca66063
Compare
mrstork
reviewed
Dec 18, 2024
packages/gatsby-source-shopify/src/create-schema-customization.ts
Outdated
Show resolved
Hide resolved
mrstork
reviewed
Dec 18, 2024
packages/gatsby-source-shopify/src/type-builders/location-type.ts
Outdated
Show resolved
Hide resolved
mrstork
reviewed
Dec 18, 2024
packages/gatsby-source-shopify/__tests__/fixtures/shopify-nodes/ShopifyCollection.json
Outdated
Show resolved
Hide resolved
mrstork
reviewed
Dec 18, 2024
packages/gatsby-source-shopify/__tests__/fixtures/shopify-nodes/ShopifyProduct.json
Outdated
Show resolved
Hide resolved
…changes-and-thus-gatsby-source
mrstork
approved these changes
Dec 18, 2024
pieh
approved these changes
Dec 18, 2024
serhalp
changed the title
Canary version released for testing purposes |
serhalp
commented
Dec 18, 2024
There was a problem hiding this comment.
LGTM. Let's add a prominent note near the top of https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-source-shopify that the package uses version 2024-04 and link to it?
pieh
deleted the
serhalp/frp-1284-shopify-api-has-breaking-changes-and-thus-gatsby-source
branch
pieh
added a commit
that referenced
this pull request
Jan 2, 2025
…4 to 2024-04 (#39082) * chore!(gatsby-source-shopify): upgrade to api version 2024-04 See breaking changes in: - https://shopify.dev/docs/api/release-notes/previous-versions/2022-07 - https://shopify.dev/docs/api/release-notes/previous-versions/2022-10 - https://shopify.dev/docs/api/release-notes/previous-versions/2023-01 - https://shopify.dev/docs/api/release-notes/previous-versions/2023-04 * test: fix fixture syntax and update snapshots * chore: handle Count type * fix: handle intentory level * test: update snapshots and mocks * test: update variants fixture * test: update inventory level mock * fix: minimize breaking changes by keeping Int type for count fields * fix: mark productBased as deprecated * address review comments * test: update snapshots --------- Co-authored-by: pieh <[email protected]> (cherry picked from commit 8252e82)
pieh
pushed a commit
that referenced
this pull request
Jan 2, 2025
…4 to 2024-04 (#39082) (#39202) * chore!(gatsby-source-shopify): upgrade to api version 2024-04 See breaking changes in: - https://shopify.dev/docs/api/release-notes/previous-versions/2022-07 - https://shopify.dev/docs/api/release-notes/previous-versions/2022-10 - https://shopify.dev/docs/api/release-notes/previous-versions/2023-01 - https://shopify.dev/docs/api/release-notes/previous-versions/2023-04 * test: fix fixture syntax and update snapshots * chore: handle Count type * fix: handle intentory level * test: update snapshots and mocks * test: update variants fixture * test: update inventory level mock * fix: minimize breaking changes by keeping Int type for count fields * fix: mark productBased as deprecated * address review comments * test: update snapshots --------- Co-authored-by: pieh <[email protected]> (cherry picked from commit 8252e82) Co-authored-by: Philippe Serhal <[email protected]>
|
This was now released in stable new major version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This upgrades the default Shopify API version in
gatsby-source-shopifyfrom2022-04to2024-04.We've made this upgrade seamless for Gatsby users by keeping the surface backwards-compatible. There are no breaking changes in fields or types.
However, when upgrading you should carefully review the Shopify API release notes because they contain several subtle behavioural changes that cannot be controlled by Gatsby. We've marked this as a major release for this reason.
See the release notes for each version here:
We didn't surface all new additional fields that have been added by Shopify in these versions. If you have fields you would like to see added, please open an issue or PR.
Related Issues
#39129