feat: allow dsg/ssr renders without access to datastore if it's not required (#38974) #38979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
…equired (#38974) * fix: generate lmdb cdn path after state was reloaded from cache restoration * feat: make lmdb datastore optional and lazy in engines * use datastore exlucde and skip deploy cleanup temporarily * fix lint * build engines after page configs were prepared * tmp: workaround local deploy problems with datastore exclussion * set rawUrl on request and use it to extract origin for engine download in case url passed at build doesn't work * no unhandled promise rejections, actually pass rawUrl * make one of e2e variants use datastore exclussion, so base case is still tested * revert adapters e2e test cleanup * scripts rename * findPageByPath renaming * getGraphqlEngine renaming (cherry picked from commit 884ecaf)
pieh
approved these changes
May 17, 2024
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #38974 to the 5.13 release branch
(cherry picked from commit 884ecaf)