fix(gatsby-adapter-netlify): handler generation on windows (#38900) #38929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: add unit test for produced handler * actually failing test in windows * fix(gatsby-adapter-netlify): produce working function handlers on windows * fix(gatsby): functions compilation on windows * tmp: prepare cross-platform binaries for SSR/DSG * fix: lint * feat: add a way to configure functions executing platform/arch and add early check in DSG/SSR * refactor: move some utility functions around, cleanup standalone-regenrate, restore engine validation, add structured error and better error messages * chore: add jsdocs description for functionsPlatform and functionsArch optional config values passed by adapter * chore: make sure fs wrapper is first * fix: actually use values reported by adapter * test: try to setup windows adapters smoke test * test: typo * test: maybe cd into dirs? * test: no powershell fro smoke test * chore: single quote to double * chore: install node-gyp requirements * chore: install deps in win smoke * ? * newer node needed for ntl-cli * run ntl through yarn * Revert "run ntl through yarn" This reverts commit 8c55e40. * install ntl-cli in circleci pipeline * test: adjust lmdb regeneration test to changed internal-packages location * test: run windows deploy/smoke test after unit tests passed * chore: use path.posix to load engines in serve command * chore: use default value when destructuring instead of nullish coalescing later (cherry picked from commit c91ed28)
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
pieh
approved these changes
Apr 10, 2024
This was referenced May 1, 2024
This was referenced May 9, 2024
This was referenced May 16, 2024
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #38900 to the 5.13 release branch
(cherry picked from commit c91ed28)