Skip to content

Conversation

gatsbybot
Copy link
Collaborator

Backporting #38758 to the 5.12 release branch

(cherry picked from commit 1953e5c)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 15, 2023
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 15, 2023
@pieh
Copy link
Contributor

pieh commented Dec 18, 2023

Note here - the failure is related to compatibility checks and gatsby-dev-cli implementation details

right now it doesn't allow gatsby-dev-cli produced version (like 1.0.4-dev-1702672314858 that is produced by it) when checking for for ^1.0.4 check (semver.satisfies(`1.0.4-dev-1702672314858`, `^1.0.4`, {includePrerelease: true}) returns false).

Some adjustments will be needed to be made so the tests are allowed to use gatsby-dev-cli produced version, but they will need to happen as part of changes outlined in #38752

For now, I'll close this and rely on upcoming 5.13 release to update the version manifest.

@pieh pieh closed this Dec 18, 2023
@mrstork mrstork deleted the backport-5.12-38758 branch February 18, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants