fix(gatsby): Prevent errors if Head has root text node
#36402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
marvinjude
added
topic: DX
marvinjude
changed the title
Head has root text node(s)
marvinjude
changed the title
Head has root text node(s)Head has root text node
marvinjude
changed the title
Head has root text nodeHead has root text node
imjoshin
approved these changes
Aug 17, 2022
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced May 15, 2024
This was referenced May 15, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent
Headfrom breaking if it contains root level text (text node)Adding some text like "Break" above will throw errors on trying to access the
attributeobject on a text node since text nodes have no attribute keyThis fix is important for users using a CMS(like WordPress where the text they're trying to pass also contains invalid head elements and root level text(s)
Documentation
https://www.gatsbyjs.com/docs/reference/built-in-components/gatsby-head/
Related Issues
A user reported this issue on discord https://discord.com/channels/484383807575687178/537691356487876624/1009100830261129356