fix(gatsby-source-wordpress): Add image cdn fields on updates #35687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
added
topic: source-wordpress
Contributor
Author
|
Canary available as |
LekoArts
pushed a commit
that referenced
this pull request
May 19, 2022
add image cdn fields on updates too (cherry picked from commit 54832b4)
LekoArts
pushed a commit
that referenced
this pull request
May 19, 2022
#35694) Co-authored-by: Tyler Barnes <[email protected]>
Contributor
|
Successfully published: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a bug where image cdn fields are not added to MediaItem nodes if those nodes are edited directly in WP - for example rotating or renaming an image. All incremental builds since the edit will fail with an image cdn error because on delta updates to MediaItems we weren't adding the right image cdn fields.
There's clearly some tech debt here as the
createMediaItemfunction is only used for initial builds, not for delta updates. I don't want to make a large refactor in this PR though so I'm adding the image cdn fields in both places with a newaddImageCDNFieldsToNodefunction.