Skip to content

fix(gatsby-source-drupal): Image cdn fixes #35619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TylerBarnes merged 6 commits into from
May 13, 2022
Merged

fix(gatsby-source-drupal): Image cdn fixes #35619

TylerBarnes merged 6 commits into from
May 13, 2022

Conversation

@TylerBarnes
Copy link
Contributor

@TylerBarnes TylerBarnes commented May 9, 2022

This PR does 2 things:

  1. Warns about corrupt files when using Image CDN and skips over them.
  2. Only registers the gatsbyImage field when skipFileDownloads is enabled. If it's not enabled it prints out a message with info about how to enable Gatsby Image CDN for Drupal.

Relates to #35147 (comment)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 9, 2022
@TylerBarnes TylerBarnes requested a review from smthomas May 9, 2022 23:09
@TylerBarnes TylerBarnes added topic: source-drupal Related to Gatsby's integration with Drupal and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 9, 2022
@imjoshin
Copy link
Contributor

imjoshin commented May 12, 2022

Looks good to me, pending the passing of non-flaky tests. 😄

@TylerBarnes TylerBarnes requested a review from veryspry May 12, 2022 22:36
KyleAMathews
KyleAMathews reviewed May 12, 2022
View reviewed changes
@TylerBarnes TylerBarnes requested a review from KyleAMathews May 12, 2022 22:54
KyleAMathews
KyleAMathews approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

@TylerBarnes TylerBarnes merged commit 15a3fbf into master May 13, 2022
@TylerBarnes TylerBarnes deleted the fix/drupal-image-cdn-fixes branch May 13, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smthomas smthomas Awaiting requested review from smthomas

@veryspry veryspry Awaiting requested review from veryspry

1 more reviewer

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: source-drupal Related to Gatsby's integration with Drupal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TylerBarnes @imjoshin @KyleAMathews