Skip to content

Conversation

@wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Mar 21, 2022

Description

Not all instances of getServerData or config are removed, the rule only applies to js, mjs & jsx files. Not it also supports ts, TSX.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 21, 2022
@wardpeet wardpeet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 21, 2022
Copy link
Contributor

@imjoshin imjoshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test method is clean, I like it 💪

@wardpeet
Copy link
Contributor Author

I just copied it from an already existing one 😂

@wardpeet wardpeet merged commit 8de18e7 into master Mar 21, 2022
@wardpeet wardpeet deleted the fix/modified-exports-ts branch March 21, 2022 14:53
pieh pushed a commit that referenced this pull request Mar 22, 2022
pieh pushed a commit that referenced this pull request Mar 22, 2022
(cherry picked from commit 8de18e7)

Co-authored-by: Ward Peeters <[email protected]>
@pieh
Copy link
Contributor

pieh commented Mar 22, 2022

Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants