Skip to content

Conversation

@tcoopman
Copy link
Contributor

Description

I've ran into a case where context was undefined resulting in:

TypeError: Cannot read properties of undefined (reading 'telemetryResolverTimings')",
          "    at wrappedTracingResolver (/home/thomas/Workspace/aardling/2022.dddeurope.com/node_modules/gatsby/src/schema/resolvers.ts:679:17)",

there was a check on if (context?.tracer) already but not on the telemtryResolverTimings

Documentation

No updates need

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 10, 2022
@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 10, 2022
@LekoArts
Copy link
Contributor

Can you push an empty commit? For some reason the CI didn't trigger a run

@tcoopman
Copy link
Contributor Author

it doesn't look like the windows_unit_tests failing has anything to do with this PR?

@LekoArts LekoArts changed the title null check for context fix(gatsby): null check for context Mar 11, 2022
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts merged commit 46e2902 into gatsbyjs:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants