chore(gatsby): cache shouldn't reference nodes strongly #34821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: core
imjoshin
changed the title
This was referenced May 26, 2022
This was referenced May 26, 2022
This was referenced May 26, 2022
This was referenced May 26, 2022
This was referenced May 26, 2022
This was referenced May 28, 2022
This was referenced May 28, 2022
This was referenced Jul 21, 2022
This was referenced Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
expirersetting explained in https://github.com/kriszyp/weak-lru-cache#expirerThis just removes strong references from lmdb cache. It doesn't mean nodes WILL be GCed - it just makes it possible (if memory need to be freed).