- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10.3k
fix(gatsby): don't remove onPluginInit in graphql-engine #34558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    wardpeet
  
              
              approved these changes
              
                  
                    Jan 21, 2022 
                  
              
              
            
            
    
  LekoArts 
      pushed a commit
      that referenced
      this pull request
    
      Jan 24, 2022 
    
    
      
  
    
      
    
  
(cherry picked from commit 135e080)
    
  LekoArts 
      pushed a commit
      that referenced
      this pull request
    
      Jan 24, 2022 
    
    
      
  
    
      
    
  
…4573) Co-authored-by: Michal Piechowiak <[email protected]>
| Published in  | 
    
  marvinjude 
      pushed a commit
      that referenced
      this pull request
    
      Jan 25, 2022 
    
    
      
  
    
      
    
  
(cherry picked from commit 135e080)
    
  pieh 
      added a commit
      that referenced
      this pull request
    
      Jan 25, 2022 
    
    
      
  
    
      
    
  
…4586) Co-authored-by: Michal Piechowiak <[email protected]>
  This was referenced Jan 25, 2022 
      
  This was referenced Jan 26, 2022 
      
  This was referenced Feb 14, 2022 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    bot: merge on green
  Gatsbot will merge these PRs automatically when all tests passes 
  
    topic: render-mode
  Related to Gatsby's different rendering modes 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
#33484 introduced a regression where
gatsby-plugin-sharpdoesn't init in engine and that result in errors on usage:Currently
gatsby/packages/gatsby-plugin-sharp/src/gatsby-node.js
Lines 132 to 145 in 3659ec2
is getting bundled as
With this change it becomes