fix(gatsby): resolve createNode promise when datastore is ready #34277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
topic: data
Contributor
We already should handle this With that said - using above as blueprint, alternative to this PR could be to create temporary map of nodes for created node and hold them in memory until operation is completed. But if you didn't see perf diff in your test, let's go with this |
:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We wait for the createNode promise to resolve until the node store is synced. I've done tests on gatsbyjs.com and 1000x benchmark MD site and didn't see an immediate change in performance. Also, most source plugins do not await node creation.
We should do the same thing for deleteNode but it changes the signature of the function. Curious what others think
Documentation
Related Issues
Fixes #33871