Skip to content

Conversation

@dmccraw
Copy link
Contributor

@dmccraw dmccraw commented Oct 25, 2021

  • Retrieve pathPrefix and assetPrefix from the config instead of the data passed in through onPostBuild which doesn't distinguish between an assetPrefix and pathPrefix

  • It would be nice to get this fix back ported to version 3 so assetPrefix properly works in Gatsby Cloud.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 25, 2021
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

@KyleAMathews KyleAMathews added type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 25, 2021
@KyleAMathews
Copy link
Contributor

I added it to the v3 backport project so it'll get done

@dmccraw dmccraw merged commit 168351e into master Oct 25, 2021
@dmccraw dmccraw deleted the dmccraw/send-proper-path-prefix branch October 25, 2021 22:07
vladar pushed a commit that referenced this pull request Oct 27, 2021
vladar pushed a commit that referenced this pull request Oct 27, 2021
wardpeet pushed a commit to herecydev/gatsby that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug An issue or pull request relating to a bug in Gatsby

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants