fix(gatsby-source-wordpress): restore PQR support #33590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
approved these changes
Oct 19, 2021
LekoArts
added
topic: source-wordpress
wardpeet
pushed a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
This was referenced Jan 25, 2022
This was referenced Feb 19, 2022
This was referenced Jan 6, 2024
This was referenced Jan 6, 2024
This was referenced Jan 6, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wardpeet I'm not sure why tests weren't failing before for your WP PQR PR but I think we need to revert it. It looks like it breaks builds for
gatsby-source-wordpressw/ Gatsby v4. The int tests are currently failing (this PR fixes them).Thinking about it a bit more that change is actually how it worked before I made
gatsby-source-wordpresswork w/ PQR. It has some caching logic to only run that ingest schema fn once every 10 seconds. The workers were failing since they didn't have the cached schema yet.