fix(gatsby-source-wordpress): Add steps for refetch_ALL
#33264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`REFETCH_ALL` action_type implemented on WPGatsby was not being handled. This takes care of that by adding a conditional for `REFETCH_ALL`, sources the Node and checks if the sourceNode has `refetchAll` boolean set in addition to other Or conditionals. To add `refetchAll` GatsbyTypes was modified to add the new property.
gatsbot
bot
added
the
status: triage needed
LekoArts
changed the title
refetch_ALL
LekoArts
added
topic: source-wordpress
2 tasks
TylerBarnes
suggested changes
Oct 12, 2021
Contributor
TylerBarnes
left a comment
TylerBarnes
left a comment
There was a problem hiding this comment.
Just one change, otherwise this looks great!
| await fetchAndCreateNonNodeRootFields() | ||
| case `REFETCH_ALL`: | ||
| helpers.refetchAll = true; | ||
| await sourceNodes(helpers, {}) |
Contributor
There was a problem hiding this comment.
Sorry for the delay here! I was out on vacation and had a lot of things to catch up on when I got back. Can we refactor this to not mutate helpers?
await sourceNodes({ ...helpers, refetchAll: true }, {})
Contributor
Author
There was a problem hiding this comment.
@TylerBarnes - Thank you for getting back and no worries! Just made the change you requested and commited.
TylerBarnes
previously approved these changes
Oct 18, 2021
Contributor
TylerBarnes
left a comment
TylerBarnes
left a comment
There was a problem hiding this comment.
Looks and works great :D thanks for this!! Looks like there are some linting issues but I'll use the Gatsby bot to fix that. Thanks again!
…y into psharma-fix-refetch-all
TylerBarnes
added
the
bot: merge on green
Contributor
|
Looks like the failling tests are unrelated so I'm going to merge this. Thanks again for this awesome contribution! 🎉 |
Contributor
Author
|
@TylerBarnes - Happy to help, thanks for your help as well! |
wardpeet
pushed a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
…3264) Co-authored-by: Tyler Barnes <[email protected]>
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
Co-authored-by: Tyler Barnes <[email protected]>
This was referenced Jan 25, 2022
This was referenced Jan 6, 2024
This was referenced Jan 6, 2024
This was referenced Jan 6, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
REFETCH_ALLaction_type implemented on WPGatsby was not being handled. This takes care of that by adding a conditional forREFETCH_ALL, sources the Node and checks if the sourceNode hasrefetchAllboolean set in addition to other Or conditionals. To addrefetchAllGatsbyTypes was modified to add the new property.Documentation
Where is this feature or API documented?
@gatsbyjs/documentation - Not sure where this is documented?
Related Issues
Link to the issue that is fixed by this PR (if there is one)
e.g. Fixes #33260
@TylerBarnes - Here's the change we talked about, I had to slightly change how I am calling sourceNodes method.