Skip to content

fix(gatsby): Assign parentSpan to activities that were missing them #33122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 13, 2021
Merged

fix(gatsby): Assign parentSpan to activities that were missing them #33122

merged 4 commits into from
Sep 13, 2021

Conversation

KyleAMathews
Copy link
Contributor

Found a number of activities that were missing their parentSpans so they were left orphaned when
examining traces.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 9, 2021
@KyleAMathews KyleAMathews added type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 9, 2021
@KyleAMathews KyleAMathews requested a review from pieh September 10, 2021 22:04
@KyleAMathews KyleAMathews mentioned this pull request Sep 11, 2021
Merged
wardpeet
wardpeet approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it but looks good to me!

@KyleAMathews KyleAMathews merged commit fc66250 into master Sep 13, 2021
@KyleAMathews KyleAMathews deleted the unorphan-spans branch September 13, 2021 17:05
This was referenced Jun 19, 2022
Open
Open
Open
This was referenced Jun 19, 2022
Open
Open
Open
@nidhi42 nidhi42 mentioned this pull request Jun 19, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Jun 19, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 19, 2022
Open
@Rutam21 Rutam21 mentioned this pull request Jun 19, 2022
Open
This was referenced Jun 19, 2022
Open
Open
@saurabharch saurabharch mentioned this pull request Jun 19, 2022
Open
This was referenced Jun 19, 2022
Open
Open
@ajesse11x ajesse11x mentioned this pull request Jun 19, 2022
Open
This was referenced Jun 19, 2022
Open
Open
This was referenced Jan 31, 2023
Open
Open
Open
Open
@0xSebin 0xSebin mentioned this pull request Jan 31, 2023
Open
This was referenced Jan 31, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@kaocher82 kaocher82 mentioned this pull request Feb 1, 2023
Open
@0xSebin 0xSebin mentioned this pull request Feb 1, 2023
Open
This was referenced Feb 1, 2023
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 3, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Mar 24, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2023
Open
@saurabharch saurabharch mentioned this pull request Jun 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieh pieh Awaiting requested review from pieh

1 more reviewer

@wardpeet wardpeet wardpeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: bug An issue or pull request relating to a bug in Gatsby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KyleAMathews @wardpeet