fix(gatsby): don't log FAST_DEV message for each worker #32961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
LekoArts
added
the
topic: core
LekoArts
approved these changes
Aug 30, 2021
vladar
pushed a commit
that referenced
this pull request
Aug 31, 2021
(cherry picked from commit e547dc3)
vladar
added a commit
that referenced
this pull request
Aug 31, 2021
) * fix(gatsby): don't log FAST_DEV message for each worker (#32961) (cherry picked from commit e547dc3) * trigger ci Co-authored-by: Michal Piechowiak <[email protected]> Co-authored-by: Vladimir Razuvaev <[email protected]>
This was referenced Aug 31, 2021
This was referenced Oct 19, 2024
This was referenced Oct 20, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FAST_DEVflag right now results in multiple copies of same logs (one for each worker), due to transitional import ingatsby/packages/gatsby/src/utils/worker/child/queries.ts
Lines 1 to 5 in 88e1559
This is absolutely not ideal, but we also can't easily move the code from import time path as it might be handled too late otherwise.
Related Issues
[ch35984]
#32389 (comment)