Skip to content

Conversation

@wardpeet
Copy link
Contributor

Description

I've noticed some unsued packages that we imported. This PR removes them, the biggest offender is webpack-dev-server

image

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 25, 2021
"devDependencies": {
"@babel/cli": "^7.14.8",
"@babel/register": "^7.14.0",
"@babel/runtime": "^7.14.8",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also in dependencies

@herecydev
Copy link
Contributor

@wardpeet what's this library/tool you used to generate the graph?

@wardpeet
Copy link
Contributor Author

@herecydev I always use https://npm.anvaka.com/#/

const childProcess = await execa(`yarn`, [`test-output`])

expect(childProcess.code).toEqual(0)
expect(childProcess.exitCode).toEqual(0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this change was necessary but code returns undefined

@wardpeet wardpeet added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 25, 2021
@wardpeet wardpeet merged commit 7c72ab8 into master Aug 26, 2021
@wardpeet wardpeet deleted the chore/cleanup-packages branch August 26, 2021 11:55
wardpeet added a commit that referenced this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants