fix(gatsby-plugin-image): Switch react-dom import to remove createRoot warning #32457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
the
topic: media
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
LekoArts
changed the title
pieh
reviewed
Jul 21, 2021
vladar
reviewed
Jul 21, 2021
Contributor
vladar
left a comment
vladar
left a comment
There was a problem hiding this comment.
Should we maybe add some greppable comment like TODO: remove in v4?
pieh
approved these changes
Jul 21, 2021
Contributor
pieh
left a comment
pieh
left a comment
There was a problem hiding this comment.
Given this follows what we do in https://github.com/gatsbyjs/gatsby/blob/29dedc398da4ba69257cf60e0e1400ebaea3c886/packages/gatsby/cache-dir/production-app.js I think we can merge it.
LekoArts
added a commit
that referenced
this pull request
Jul 21, 2021
…t warning (#32457) (#32458) (cherry picked from commit 9595ccb) Co-authored-by: Lennart <[email protected]>
Contributor
Author
|
Published in |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The named imports were a bit over eager in the initial PR (#32378) so this switches it to default import via
ReactDOM. We do the same incache-dir/app.js.Related Issues
Fixes #32451
[ch34846]