fix(gatsby-plugin-gatsby-cloud): Copying manifest #31092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: functions
and removed
status: triage needed
ascorbic
approved these changes
Apr 28, 2021
LekoArts
added a commit
that referenced
this pull request
Apr 28, 2021
(cherry picked from commit a9ad91f)
LekoArts
added a commit
that referenced
this pull request
Apr 28, 2021
Co-authored-by: Lennart <[email protected]>
Contributor
Author
|
Published in |
LekoArts
added
the
topic: DX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was introduced in #30904. When having
gatsby-plugin-gatsby-cloudinstalled but not using functions then the manifest file doesn't exists and thus can't be copied.In the first step of this PR I added
gatsby-plugin-gatsby-cloudto an integration test without any function call and the test fails as expected: https://app.circleci.com/pipelines/github/gatsbyjs/gatsby/62308/workflows/159728d1-333c-4f51-bba2-10ab0b0b6a7b/jobs/680283The second commit fixed it by checking for the existence of the manifest file and the test
gatsby-pipelinenow should pass.Related Issues
Fixes #31090