Skip to content

Conversation

herecydev
Copy link
Contributor

Description

Adds a "ltr" direction to prevent issues when working within "rtl" sites. The most problematic fix is the stack trace which gets completely mangled:

Screenshot 2021-03-01 203731

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 1, 2021
@LekoArts LekoArts added topic: hot reloading and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 2, 2021
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, great catch! Thanks for finding this and opening a PR to fix it! 🤗

@LekoArts LekoArts changed the title Add dir to overlay fix(gatsby): Add dir=ltr to Fast Refresh overlay Mar 2, 2021
@LekoArts LekoArts merged commit 89d3150 into gatsbyjs:master Mar 2, 2021
vladar pushed a commit that referenced this pull request Mar 2, 2021
@herecydev
Copy link
Contributor Author

No problem 🚀

vladar pushed a commit that referenced this pull request Mar 2, 2021
(cherry picked from commit 89d3150)

Co-authored-by: Dan Kirkham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants