Skip to content

Conversation

@merceyz
Copy link
Contributor

@merceyz merceyz commented Dec 26, 2020

Description

gatsby-plugin-sharp and gatsby-react-router-scroll is depending on some packages without without declaring them so this PR makes them explicit

Documentation

N/A

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 26, 2020
@LekoArts LekoArts added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 4, 2021
9rstpn
9rstpn previously approved these changes Jan 5, 2021
@merceyz merceyz force-pushed the merceyz/missing-deps branch from 52e07c1 to 4e25e80 Compare January 5, 2022 13:32
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pieh pieh merged commit d20c97b into gatsbyjs:master Jan 19, 2022
@merceyz merceyz deleted the merceyz/missing-deps branch January 19, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants