feat(gatsby): use graphiql-explorer #14280
Conversation
| @@ -0,0 +1,53 @@ | |||
| { | |||
| "name": "gatsby-graphiql-explorer", | |||
There was a problem hiding this comment.
this probably need better package name - this is kind of express middleware, but not exactly, because it's not used as express.use(someMiddleware()), instead it is used as graphiqlExplorer(expressApp, params) as I need to have 2 route handlers (one for html and one for bundle)
There was a problem hiding this comment.
It's easy to bike shed here--I don't really have a problem with the name. We could also scope it, e.g. @gatsbyjs/graphiql which is really what we've done here. We tweaked graphiql with some extra functionality.
|
@pieh |
DSchau
left a comment
DSchau
left a comment
There was a problem hiding this comment.
Looks good to me, left some comments.
In general, I don't necessarily think that:
- Name change should block, nor
- Default GraphiQL query should block
I think this is useful enough to ship. Great work!
| @@ -0,0 +1,16 @@ | |||
| # gatsby-graphiql-explorer | |||
There was a problem hiding this comment.
Simple and concise 🤷♂ I think this will suffice!
Co-Authored-By: Dustin Schau <[email protected]>
Co-Authored-By: Dustin Schau <[email protected]>
|
Will try to figure better tests e2e tests tomorrow, not quite sure why failing test is flaking in CircleCi |
e2e-tests/development-runtime/cypress/integration/functionality/graphql-endpoint.js
Outdated
Show resolved
Hide resolved
…y/graphql-endpoint.js Co-Authored-By: Dustin Schau <[email protected]>
|
@pieh - question, how does this impact https://www.gatsbyjs.org/docs/using-graphql-playground/ ? Is the GraphQL Playground also updated with this feature? If not, should that be mentioned in the Docs or Blog post? |
Replace current bare graphiql with graphiql-explorer + graphiql
Additional benefit that is not really related to graphiql-explorer, but implemented here:
new graphiql integration doesn't use external resources (currently used
express-graphqluses https://cdn.jsdelivr.net to get react, react-dom, graphiql etc to render app correctly. This will use local bundle, so you can use it no problem on planes ;)TO-DO:
Closes #11602