Skip to content

Conversation

@sbardian
Copy link
Contributor

Description

After adding pluginOptions as a parameter I noticed Return value was right up against pluginOptions parameter. Return value did not have the top margin that Example has.

Related Issues

N/A

@sbardian sbardian requested a review from a team March 13, 2019 17:40
@sbardian
Copy link
Contributor Author

See PR #12547 about adding pluginOptions to docs.

@DSchau DSchau changed the title Add top margin to Return value chore(www): add top margin to Return value Mar 13, 2019
@pieh
Copy link
Contributor

pieh commented Mar 13, 2019

Hey, I will merge #12087 shortly that changes API reference components, but I will handle transplanting your change after that merge

@pieh
Copy link
Contributor

pieh commented Mar 13, 2019

Hey, with new api reference components - this is how it looks like (without any styling changes from this PR):
Screenshot 2019-03-14 at 00 53 44

This seems ok to me as-is - let me know if you still would want to apply changes here

@sbardian
Copy link
Contributor Author

Nope, looks good to me too!

@pieh
Copy link
Contributor

pieh commented Mar 14, 2019

Nope, looks good to me too!

All right, so I'll close this one and we can handle #12547 without this being a blocker.

@pieh pieh closed this Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants