Gatsby's .eslintignore being ignored

[NMinhNguyen]

Gatsby version: 0.12.45

Hi, I noticed that npm test on master fails due to some linting problems in interfaces folder, however this folder is actually specified in .eslintignore. But because linting is configured with --ignore-path .gitignore in package.json, .eslintignore is ignored in favour of .gitignore.

{
  "scripts": {
    "lint": "eslint --ext .js,.jsx --ignore-path .gitignore ."
  }
}

From ESLint docs:

Keep in mind that specifying --ignore-path means that any existing .eslintignore file will not be used.

Short of copying the contents of .gitignore into .eslintignore, I'm not sure what the best way to combine .eslintignore and .gitignore is.

You can scroll to the bottom of this recent build log to see the exact error

[KyleAMathews]

So it turns out you can add multiple --ignore-path! bd068fd :-)

https://travis-ci.org/gatsbyjs/gatsby/builds/224775750

Thanks for doing the background research on this!

[NMinhNguyen]

I'm afraid that's not true 😔 I had a dist folder on my machine, and it tried to lint it, with your changes. I think the last --ignore-path wins - try swapping .eslintignore and .gitignore, and you'll see that the interfaces folder isn't being ignored again.

$ DEBUG=eslint:* npm run lint

> gatsby@0.12.45 lint /path/to/gatsby
> eslint --ext .js,.jsx --ignore-path .gitignore --ignore-path .eslintignore .

  eslint:cli Running on files +0ms
  eslint:glob-util Creating list of files to process. +20ms
  eslint:ignored-paths Using specific ignore file +4ms
  eslint:ignored-paths Adding .eslintignore +0ms

[KyleAMathews]

Oh hmmm...

[NMinhNguyen]

An easy (but not very scalable/optimal) solution would be to perhaps use --ignore-pattern interfaces?

[KyleAMathews]

I guess we could just ignore the interfaces directory directly in the command. Trying that 06a4b45

[KyleAMathews]

Heh, our brain waves connected!

[NMinhNguyen]

It worked! Works locally as well, with an existing dist folder :)

[KyleAMathews]

💯