[gatsby-plugin-manifest] Automatic mode error: Cannot read property '0' of undefined

[alampros]

Description

When running the plugin with no icons property in the options (only icon for the source image), gatsby build throws a build error.

Error: Cannot read property '0' of undefined

  - render-page.js:22888 Object.exports.onRenderBody
    render-page.js:22888:24

Steps to reproduce

1. Configure gatsby-plugin-manifest as described in Automatic Mode
2. Run gatsby build

Expected result

The plugin should use the defaultIcons from:

gatsby/packages/gatsby-plugin-manifest/src/gatsby-node.js

Lines 6 to 47 in 362f78a

	const defaultIcons = [
	{
	"src": `icons/icon-48x48.png`,
	"sizes": `48x48`,
	"type": `image/png`,
	},
	{
	"src": `icons/icon-72x72.png`,
	"sizes": `72x72`,
	"type": `image/png`,
	},
	{
	"src": `icons/icon-96x96.png`,
	"sizes": `96x96`,
	"type": `image/png`,
	},
	{
	"src": `icons/icon-144x144.png`,
	"sizes": `144x144`,
	"type": `image/png`,
	},
	{
	"src": `icons/icon-192x192.png`,
	"sizes": `192x192`,
	"type": `image/png`,
	},
	{
	"src": `icons/icon-256x256.png`,
	"sizes": `256x256`,
	"type": `image/png`,
	},
	{
	"src": `icons/icon-384x384.png`,
	"sizes": `384x384`,
	"type": `image/png`,
	},
	{
	"src": `icons/icon-512x512.png`,
	"sizes": `512x512`,
	"type": `image/png`,
	},
	]

...and

1. generate the default set of images
2. populate the icons property of the manifest.json with the default icons

Actual result

Build throws error:

Error: Cannot read property '0' of undefined

  - render-page.js:22888 Object.exports.onRenderBody
    render-page.js:22888:24

Environment

• Gatsby version (npm list gatsby): 1.9.246
• gatsby-cli version (gatsby --version): 1.9.246
• Node.js version: v8.11.0
• Operating System: macOS 10.13.4

File contents (if changed):

gatsby-config.js:

    {
      resolve: 'gatsby-plugin-manifest',
      options: {
        name: pkg.title,
        short_name: pkg.shortName,
        start_url: '/',
        background_color: '#DFE7F7',
        theme_color: '#00A3DB',
        display: 'minimal-ui',
        icon: 'src/icon.png',
      },
    },
    'gatsby-plugin-offline',

[cjkihl]

+1 on this one. I get the same error.

[pieh]

@caki0915 There is PR with fix for this #4867 , but in meantime you can downgrade to gatsby-plugin-manifest@1.0.15

[KyleAMathews]

Fix is published to NPM so update to the latest gatsby-plugin-manifest.

[williamtstanley]

Hmm I still get a simalar error using the default "Automatic" setup for this plugin.

{
      resolve: `gatsby-plugin-manifest`,
      options: {
        name: `FitplanApp`,
        short_name: `FitplanApp`,
        start_url: `/`,
        background_color: `#e6e6e6`,
        theme_color: `#00000`,
        display: `minimal-ui`,
        icon: `src/data/images/icon.png`, // This path is relative to the root of the site.
      },
    },

Error:

 Oh no, error occured:  Error: Array Methods must be provided an Array
    at validationError (/home/travis/Development/fitplan/website/node_modules/es6-promise/dist/es6-promise.js:481:10)
    at new Enumerator (/home/travis/Development/fitplan/website/node_modules/es6-promise/dist/es6-promise.js:509:28)
    at Function.all (/home/travis/Development/fitplan/website/node_modules/es6-promise/dist/es6-promise.js:626:10)
    at tokenPromise.then.res (/home/travis/Development/fitplan/website/plugins/gatsby-source-fitplan/gatsby-node.js:104:20)
    at tryCatcher (/home/travis/.nvm/versions/node/v10.9.0/lib/node_modules/gatsby-cli/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/travis/.nvm/versions/node/v10.9.0/lib/node_modules/gatsby-cli/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/home/travis/.nvm/versions/node/v10.9.0/lib/node_modules/gatsby-cli/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/home/travis/.nvm/versions/node/v10.9.0/lib/node_modules/gatsby-cli/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/home/travis/.nvm/versions/node/v10.9.0/lib/node_modules/gatsby-cli/node_modules/bluebird/js/release/promise.js:693:18)
    at Async._drainQueue (/home/travis/.nvm/versions/node/v10.9.0/lib/node_modules/gatsby-cli/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/home/travis/.nvm/versions/node/v10.9.0/lib/node_modules/gatsby-cli/node_modules/bluebird/js/release/async.js:143:10)
    at Immediate.Async.drainQueues (/home/travis/.nvm/versions/node/v10.9.0/lib/node_modules/gatsby-cli/node_modules/bluebird/js/release/async.js:17:14)
    at runCallback (timers.js:693:18)
    at tryOnImmediate (timers.js:664:5)
    at processImmediate (timers.js:646:5)`