Set NODE_ENV=production on node process when running "gatsby build"

[emilyaviva]

I am finishing a Gatsby-ified version of my personal website (http://emilyaviva.github.io/eakm-website-gatsby) and a sticking point seems to be that when the source (http://github.com/emilyaviva/eakm-website-gatsby) is run normally in develop mode, the font-awesome fonts get included, but when it is actually built, the font-awesome fonts don't make it in, somehow. My guess is this has to do with the Webpack loader config, but I'm not sure how. Any ideas?

[KyleAMathews]

TBH, I haven't tried loading fonts with Gatsby. Someone else contributed the font webpack config here

gatsby/lib/utils/webpack.config.js

Lines 255 to 258 in aeccf94

	// Font loaders
	config.loader('woff', {
	test: /\.woff(2)?(\?v=[0-9]\.[0-9]\.[0-9])?$/,
	loader: 'url-loader?limit=10000&minetype=application/font-woff',

It is setup to run the same though in both develop and production.

[emilyaviva]

It worked fine once I built it with NODE_ENV=production. All I've done, in my index.js, is import 'font-awesome/scss/font-awesome.scss', which uses the built-in Sass loader. I haven't needed to mess with custom loaders for woff, ttf, etc. files.

I like it when things Just Work™! :)

[KyleAMathews]

Mmmm... I've heard people say this before and it just occurred to me why. We autoset NODE_ENV=production on gatsby build in the Webpack build but that only applies to inside Webpack e.g. the React.js code and not to stuff outside of the Webpack context e.g. Webpack loaders. I don't have time to throughly investigate this right now but I'm guessing that's the problem and the solution would be to set process.env.NODE_ENV = 'production' on startup when running gatsby build. I'm going to re-open this issue and change the title.

[KyleAMathews]

@emilyaviva this is going out in a new release in a sec. Would be very appreciative if you could upgrade and see if the issue is in fact resolved.

[ivanoats]

I think this does it! Thanks Kyle, you have been rockin' today 🚀

[KyleAMathews]

:D thanks!
On Tue, Jul 5, 2016 at 8:37 PM Ivan Storck notifications@github.com wrote:

I think this does it! Thanks Kyle, you have been rockin' today 🚀

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#337 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAEVh9TAPu5KZDfAzjaXy_NLNVEVXmP9ks5qSyMLgaJpZM4I4t0k
.

[emilyaviva]

fixz0r3d!