Skip to content

Conversation

frano-m
Copy link
Contributor

@frano-m frano-m commented Aug 14, 2025

Closes #700.

This pull request introduces a column filter feature and refactors the table implementation in the ENA Sequencing Data Collection Selector. The main improvements are the addition of a reusable column filtering UI, centralization of column definitions, and enhanced table filtering capabilities, resulting in a more maintainable and user-friendly component.

Column Filtering Feature:

  • Added a new ColumnFilters component that provides a UI for filtering table columns, leveraging shared filter components from the UI library. This component is integrated into the CollectionSelector dialog above the table. [1] [2] [3] [4] [5]

Table Refactor and Enhancements:

  • Centralized all table column definitions into a new columnDef.ts file, improving maintainability and consistency.
  • Refactored the useTable hook to use the new column definitions, added state management for column filters, and enabled advanced filtering features such as faceted and array-based filtering.
  • Removed the now-unnecessary constants.ts file and inlined relevant metadata.
  • Updated the table and dialog layout styles to better accommodate the new filter UI and improve the overall appearance. [1] [2] [3] [4]

Bug Fix:

  • Fixed a type issue in the buildFastqFTP function to ensure correct handling of cell values.
image image image

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds column filtering functionality to the ENA Sequencing Data Collection Selector and refactors the table implementation for better maintainability. The main goal is to enable users to filter table data by various column values through a dedicated filtering UI.

  • Introduces a new ColumnFilters component with reusable filter UI elements
  • Centralizes column definitions into a dedicated columnDef.ts file for better organization
  • Enhances the table hook with filtering capabilities including faceted and array-based filtering

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
viewBuilders.ts Updates type signature and adds string conversion for the buildFastqFTP function
hook.ts Refactors table hook to use centralized column definitions and adds filtering state management
constants.ts Removes file as metadata is now inlined in the new column definitions
columnDef.ts Creates centralized column definitions with filtering configuration
table.tsx Adds grid wrapper component for improved layout
table.styles.ts Extracts grid styling and improves layout structure
ColumnFilters (types.ts, columnFilters.tsx, columnFilters.styles.ts) Implements new column filtering component with proper styling
collectionSelector.tsx Integrates the new column filters into the dialog
collectionSelector.styles.ts Updates dialog layout to accommodate the filter sidebar

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@frano-m frano-m force-pushed the fran/700-ena-seq-filters branch from ab29e93 to 7ede560 Compare August 14, 2025 07:35
@NoopDog
Copy link
Collaborator

NoopDog commented Aug 14, 2025

Hi @frano-m can you base this on #698 plz! Thx!

@frano-m frano-m force-pushed the fran/700-ena-seq-filters branch 2 times, most recently from 33645c0 to bbcb568 Compare August 18, 2025 04:38
@frano-m frano-m marked this pull request as ready for review August 18, 2025 04:44
@frano-m frano-m moved this to Ready for Review in BRC development tasks Aug 18, 2025
@frano-m frano-m force-pushed the fran/700-ena-seq-filters branch from b40fd79 to de2bac6 Compare August 18, 2025 04:55
@NoopDog NoopDog merged commit edc4eb2 into main Aug 18, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in BRC development tasks Aug 18, 2025
@frano-m frano-m deleted the fran/700-ena-seq-filters branch August 18, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add ungrouped column filters to read run
2 participants