-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add ungrouped column filters to read run (#700) #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds column filtering functionality to the ENA Sequencing Data Collection Selector and refactors the table implementation for better maintainability. The main goal is to enable users to filter table data by various column values through a dedicated filtering UI.
- Introduces a new
ColumnFilters
component with reusable filter UI elements - Centralizes column definitions into a dedicated
columnDef.ts
file for better organization - Enhances the table hook with filtering capabilities including faceted and array-based filtering
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
viewBuilders.ts | Updates type signature and adds string conversion for the buildFastqFTP function |
hook.ts | Refactors table hook to use centralized column definitions and adds filtering state management |
constants.ts | Removes file as metadata is now inlined in the new column definitions |
columnDef.ts | Creates centralized column definitions with filtering configuration |
table.tsx | Adds grid wrapper component for improved layout |
table.styles.ts | Extracts grid styling and improves layout structure |
ColumnFilters (types.ts, columnFilters.tsx, columnFilters.styles.ts) | Implements new column filtering component with proper styling |
collectionSelector.tsx | Integrates the new column filters into the dialog |
collectionSelector.styles.ts | Updates dialog layout to accommodate the filter sidebar |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ep/components/ENASequencingData/components/CollectionSelector/hooks/UseTable/viewBuilders.ts
Show resolved
Hide resolved
ab29e93
to
7ede560
Compare
33645c0
to
bbcb568
Compare
b40fd79
to
de2bac6
Compare
Closes #700.
This pull request introduces a column filter feature and refactors the table implementation in the ENA Sequencing Data Collection Selector. The main improvements are the addition of a reusable column filtering UI, centralization of column definitions, and enhanced table filtering capabilities, resulting in a more maintainable and user-friendly component.
Column Filtering Feature:
ColumnFilters
component that provides a UI for filtering table columns, leveraging shared filter components from the UI library. This component is integrated into theCollectionSelector
dialog above the table. [1] [2] [3] [4] [5]Table Refactor and Enhancements:
columnDef.ts
file, improving maintainability and consistency.useTable
hook to use the new column definitions, added state management for column filters, and enabled advanced filtering features such as faceted and array-based filtering.constants.ts
file and inlined relevant metadata.Bug Fix:
buildFastqFTP
function to ensure correct handling of cell values.