fix: only one of two paired fastq listed in workflow stepper (#578) #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors Fastq FTP processing, streamlines cell rendering, and simplifies table column definitions.
- Introduces
buildFastqFTPto replace the oldgetFastqFTPlogic and remove its file. - Updates
useTableto usebuildFastqFTPfor the “Fastq FTP” column and drops redundantBasicCelldeclarations. - Removes the
noWrapprop fromBasicCellfor more flexible text rendering.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| viewBuilders.ts | Added buildFastqFTP utility to process semicolon-separated FTP URLs. |
| hook.ts | Updated useTable to import/use buildFastqFTP and removed getFastqFTP import and duplicate cell: BasicCell entries. |
| accessorFn.ts | Deleted the old getFastqFTP function file. |
| basicCell.tsx | Removed the noWrap prop from the Typography in BasicCell. |
NoopDog
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #578.
This pull request refactors how Fastq FTP data is processed and displayed in the table component, improves the handling of cell rendering, and removes redundant code. The most important changes include replacing the
getFastqFTPfunction with a newbuildFastqFTPutility, modifying theBasicCellcomponent usage, and simplifying column definitions in theuseTablehook.Refactoring Fastq FTP processing:
buildFastqFTPfunction inviewBuilders.tsto process Fastq FTP values, transforming semicolon-separated URLs into a comma-separated string of their last parts. This replaces the removedgetFastqFTPfunction. ([[1]](https://github.com/galaxyproject/brc-analytics/pull/603/files#diff-20e967ed605f3b47c7b0abe8bc8b18d1d1e404b2a922362d8b2b01c638e84eefR1-R30),[[2]](https://github.com/galaxyproject/brc-analytics/pull/603/files#diff-963b15643594690e86c2611f0c5aec47db7dcaf1964495ff7866b97fd45c5914L1-L12))Cell rendering improvements:
BasicCellcomponent to remove thenoWrapprop, ensuring better flexibility in text rendering. ([app/components/Entity/components/ConfigureWorkflowInputs/components/Main/components/Stepper/components/Step/PairedEndStep/components/ENASequencingData/components/CollectionSelector/components/Table/components/TableCell/components/BasicCell/basicCell.tsxL11-R11](https://github.com/galaxyproject/brc-analytics/pull/603/files#diff-e57a33691433ad32d18b8b2175587349cba2380b6569b330e3528d72d70469edL11-R11))useTablehook to use thebuildFastqFTPfunction for the "Fastq FTP" column and adjusted howBasicCellis invoked for dynamic cell rendering. ([[1]](https://github.com/galaxyproject/brc-analytics/pull/603/files#diff-b0df6cf594d8eb508f9167ebcb579d30ac65c62f570204904143b6265426e139L14-R14),[[2]](https://github.com/galaxyproject/brc-analytics/pull/603/files#diff-b0df6cf594d8eb508f9167ebcb579d30ac65c62f570204904143b6265426e139L26-L92))Simplification of column definitions:
cell: BasicCelldefinitions for multiple columns in theuseTablehook, streamlining the column configuration. ([app/components/Entity/components/ConfigureWorkflowInputs/components/Main/components/Stepper/components/Step/PairedEndStep/components/ENASequencingData/components/CollectionSelector/hooks/UseTable/hook.tsL26-L92](https://github.com/galaxyproject/brc-analytics/pull/603/files#diff-b0df6cf594d8eb508f9167ebcb579d30ac65c62f570204904143b6265426e139L26-L92))