fix: make consistent navigation behavior between sunburst and side panel (#557) #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannon
reviewed
May 30, 2025
| } else if (onClose) { | ||
| // Fallback to onClose if parent is not available | ||
| onClose(); | ||
| } |
There was a problem hiding this comment.
Looks like this should be tightened up a tad -- for certain values of onClose, onNodeClick it'd be possible to exit the function without doing anything at all onClick? (not sure if this happens in our data at all, but we should just update the render condition above)
hunterckx
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #557