feat: add stub of SANGER_READ_RUN workflow parameter variable (#459) #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterckx
commented
Apr 4, 2025
| @@ -58,7 +58,8 @@ | |||
| "jsdoc/check-alignment": "error", | |||
| "jsdoc/check-param-names": "error", | |||
| "react-hooks/exhaustive-deps": "error", | |||
| "sonarjs/redundant-type-aliases": "warn" | |||
| "sonarjs/redundant-type-aliases": "warn", | |||
| "sonarjs/todo-tag": "warn" | |||
There was a problem hiding this comment.
I put in a TODO comment on the placeholder switch case, so I had to add this so that ESLint would allow me to make a commit
(To be clear this is how we've handled this ESLint rule in other apps)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minimal (just adding a new value to the enum and a placeholder case to the switch statement), but I think this is all that's useful to do unless we have a specific plan for what the relevant input and output to
paramVariableToRequestValueneeds to look likeHopefully I spelled "Sanger" correctly -- I think it's misspelled in the ticket