Ena interface #359
Draft
Ena interface #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smeds
commented
Mar 6, 2025
| } from "app/apis/catalog/brc-analytics-catalog/common/entities"; | ||
| import { NextResponse } from "next/server"; | ||
|
|
||
| const items_limit = 10000; |
There was a problem hiding this comment.
max allowed items return, should maybe be configurable
Smeds
commented
Mar 6, 2025
| setStatistics: React.Dispatch<React.SetStateAction<ReadRunStatistics>> | ||
| ): Promise<{ status: number }> => { | ||
| try { | ||
| const response = await fetch(`http://127.0.0.1:3000/api/ena`, { |
There was a problem hiding this comment.
url to api should be configurable
|
@NoopDog here's a first version of the view. If possible I would like to get some help to move it into the data selector page and also to get your input of how to make it more configurable. I will be away next week due to the kids having spring break. |
|
I can fix the stuff If I get some guidance of where to put stuff:
|
|
Here's a new prototype of the Editor I will upload the changes tomorrow, new to clean up the code |
|
I have started submitting smaller pull-request to introduce these changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first version of a viewer for ENA data:
There's still a bunch of improvements and formatting that can be done:
http://127.0.0.1:3000/api/enashould we have a search button to initiate search and validation instead of triggering on every input event?