shortcuts without modifier keys prevent writing that key in inputs

[nfcampos]

<DockMonitor toggleVisibilityKey='s'>
  <LogMonitor/>
</DockMonitor>

Hi,

setting a shortcut like that (without a modifier key) prevents me from typing that letter in inputs (because handleKeyDown() calls event.preventDefault())

one solution for this would be to add this line
if (e.target !== document.body) return
to handleKeyDown() because if an input is focused the target of the keydown event is that input, if no input is focused the target of the event is the body

another solution would be to return if the tag name of the target of the event is input, textarea, etc.

would you be open to doing one of these things, or some other way of not triggering the shortcuts while an input is focused?

Thanks,
Nuno

(also, thanks a lot for all you've done with redux,etc it plays a big part in how i write apps now 😃 )

[gaearon]

Thanks for kind words.
Why not just set a shortcut with modifier key?

[nfcampos]

that was just because this app i'm working on has other shortcuts like that (without modifier key) and it was just to be consistent. (the shortcut library https://craig.is/killing/mice i use for the other shortcuts does this thing of not triggering them when focused on an input)

[gaearon]

I'm happy to add a check like this. Want to send a PR?

[nfcampos]

done :)

[gaearon]

Fixed by #30.