Skip to content

(regression) hook order change is causing React error #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 16, 2019
Merged

(regression) hook order change is causing React error #1394

merged 4 commits into from
Nov 16, 2019

Conversation

theKashey
Copy link
Collaborator

fixes #1393

  • update patch to remove current$$1.elementType === element.type condition, so our comparison would be used in all cases.
  • rollback fiber auto-update. Might reintroduce 4.12.13 breaks hot reloading in some cases #1342, not there is no choice (keep the elementType)

@theKashey theKashey merged commit 35d329c into master Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Hooks reset" not working

1 participant

@theKashey