Skip to content

Conversation

Bnaya
Copy link
Contributor

@Bnaya Bnaya commented Aug 9, 2019

Fixes #1319

I didn't really checked it. just the rest are passing (Or just failing as the few fails on master)

@Bnaya
Copy link
Contributor Author

Bnaya commented Aug 9, 2019

After re-looking at the tests - its not same tests that failing now,
And less tests are running.
Closing this PR for now

@Bnaya Bnaya closed this Aug 9, 2019
@Bnaya Bnaya reopened this Aug 9, 2019
@Bnaya
Copy link
Contributor Author

Bnaya commented Aug 9, 2019

I've re-opened it for the CI checks.
I've made small changes to the test suite, and also excluded react 15
I don't know what's the issue with REACT 15 or with the missing throws.
Probably you will know better

@theKashey
Copy link
Collaborator

I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React 16.9.0 support webpack plugin

2 participants