Skip to content

svg: make detection harder #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025
Merged

svg: make detection harder #674

merged 4 commits into from
May 30, 2025

Conversation

gabriel-vasile
Copy link
Owner

previously: anything that contains <svg is SVG
after: must have XML header and <svg or <svg with correct xmlns attribute

Closes #673

The markup package is needed to be shared between both magic detection
functions and the charset extraction functions.
previously: anything that contains <svg is SVG
after: must have XML header and <svg or <svg with correct xmlns attribute
@gabriel-vasile gabriel-vasile marked this pull request as ready for review May 30, 2025 14:21
@gabriel-vasile gabriel-vasile merged commit 4df4dea into master May 30, 2025
3 of 4 checks passed
@gabriel-vasile gabriel-vasile deleted the svg branch May 30, 2025 14:25
@gabriel-vasile gabriel-vasile restored the svg branch June 8, 2025 08:09
@gabriel-vasile gabriel-vasile deleted the svg branch June 8, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Csv files are detected as SVG if any columns contains the string "<svg" in it
1 participant