Classify more hard keywords as such in the grammar #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grammar. This is more consistent with how other languages classify tokens, and better compatible with color themes. Also, IntelliJ doesn't make a distinction between different hard keywords, so we likely won't need to, either. IIUC, the `storage.type` scope is a better fit for types, not declaration kinds.
|
Nice, thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more consistent with how other languages classify tokens, and better compatible with color themes. Also, IntelliJ doesn't make a distinction between different hard keywords, so we likely don't need to, either.
storage.typescope seems to be a better fit for types, not declaration kinds. Examples:storage.type.primitive.array.javaforboolean[],storage.type.local.javafor itsvar(which is "type"-y),storage.modifier.javafor "class" andkeyword.other.package.javafor "package".keyword.function.goforfunc,storage.type.boolean.goforbool.There is another issue with keywords in this case which I couldn't fix right away: in
fun f(a: suspend () -> Unit),suspendis classified asentity.name.type.kotlin. IIUC, this is because somehow we end up intype-parameterrule instead of in keywords.