Skip to content

chore: Update types for user_information in session #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jimmycallin merged 2 commits into from
Oct 16, 2024
Merged

chore: Update types for user_information in session #271

jimmycallin merged 2 commits into from
Oct 16, 2024

Conversation

@swetapadmanabhan
Copy link
Contributor

@swetapadmanabhan swetapadmanabhan commented Oct 15, 2024 •
edited
Loading

  • I have added automatic tests where applicable
  • The PR title is suitable as a release note
  • The PR contains a description of what has been changed
  • The description contains manual test instructions

Changes

  • Added types for first_name, last_name, thumbnail_id, thumbnail_url in session information.

@swetapadmanabhan swetapadmanabhan self-assigned this Oct 15, 2024
@swetapadmanabhan swetapadmanabhan requested a review from a team as a code owner October 15, 2024 12:36
@swetapadmanabhan swetapadmanabhan requested review from jimmycallin and removed request for a team October 15, 2024 12:36
@swetapadmanabhan swetapadmanabhan changed the title chore: Add types for first_name and last_name to session information chore: Update types for user_information in session Oct 16, 2024
@jimmycallin jimmycallin merged commit d75a682 into main Oct 16, 2024
@jimmycallin jimmycallin deleted the add-name-property-to-user-information branch October 16, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmycallin jimmycallin jimmycallin approved these changes

Assignees

@swetapadmanabhan swetapadmanabhan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swetapadmanabhan @jimmycallin