Skip to content

propagating translation failure #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: freshservice_staging
Choose a base branch
from
Draft

propagating translation failure #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3cad66
propagating translation failure
AmitFRSH Oct 15, 2024
6e67ed3
checking registration flow
AmitFRSH Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion client/src/main/java/com/netflix/conductor/client/http/MetadataClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,11 @@ public void validateWorkflowDef(WorkflowDef workflowDef) {
*/
public void updateWorkflowDefs(List<WorkflowDef> workflowDefs) {
Validate.notNull(workflowDefs, "Workflow defs list cannot be null");
put("metadata/workflow", null, workflowDefs);
try {
put("metadata/workflow", null, workflowDefs);
} catch (Exception e) {
throw new RuntimeException("Error while updating workflow definitions", e);
}
}

/**
Expand Down
5 changes: 4 additions & 1 deletion java-sdk/src/main/java/com/netflix/conductor/sdk/workflow/executor/WorkflowExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,14 +218,17 @@ public void shutdown() {

public boolean registerWorkflow(WorkflowDef workflowDef, boolean overwrite) {
try {
LOGGER.info("^CONDUCTOR^: Starting workflow registration for: " + workflowDef.getName());
if (overwrite) {
metadataClient.updateWorkflowDefs(Arrays.asList(workflowDef));
} else {
metadataClient.registerWorkflowDef(workflowDef);
}
LOGGER.info("^CONDUCTOR^: Workflow registration successful for: " + workflowDef.getName());
return true;
} catch (Exception e) {
LOGGER.error(e.getMessage(), e);
LOGGER.error("^CONDUCTOR^: Workflow registration failed for: "
+ workflowDef.getName() + ", error: " + e.getMessage(), e);
return false;
}
}
Expand Down