Skip to content

Conversation

@sanity
Copy link
Collaborator

@sanity sanity commented Jan 1, 2026

Problem

When a user encounters a version mismatch with the gateway, the warning message gets cluttered by tracing metadata appended directly after the instructions:

Version incompatibility with gateway
  Your client version: 0.1.72
  Gateway version: 0.1.73

  To fix this, update your Freenet client:
    cargo install --force freenet --version 0.1.73

  Or if building from source:
    git pull && cargo install --path crates/core, direction: "outbound"
    at C:\Users\Administrator\.cargo\registry\src\...\connection_handler.rs:747

The , direction: "outbound" and source location appear on the same line as the instructions, making the message hard to read.

Reported by user "dredd" on Matrix.

Approach

Remove extraneous tracing fields (peer_addr, direction, message) from this specific log call. The error message itself is user-facing and contains all the necessary information - the extra metadata adds no value and clutters the output.

The warning now simply logs the error, which produces a clean multi-line message without trailing metadata.

Testing

  • This is a cosmetic logging change with no behavioral impact
  • Verified fmt and clippy pass

[AI-assisted - Claude]

Remove extraneous tracing fields (peer_addr, direction) from the version
mismatch warning. The error message itself is user-facing and contains
instructions for updating - extra metadata from tracing cluttered the output.

Before:
```
Version incompatibility with gateway
  Your client version: 0.1.72
  Gateway version: 0.1.73
  ...
  Or if building from source:
    git pull && cargo install --path crates/core, direction: "outbound"
    at C:\Users\...\connection_handler.rs:747
```

After: Clean multi-line message without trailing metadata.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@sanity sanity enabled auto-merge January 1, 2026 00:57
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

⚠️ Performance Benchmark Regressions Detected

The following benchmarks show performance regression compared to the baseline:

See workflow summary for details

Note: This is informational only and does not block the PR. Please review if the regression is expected or needs investigation.

View full benchmark results

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

⚠️ Performance Benchmark Regressions Detected

The following benchmarks show performance regression compared to the baseline:

See workflow summary for details

Note: This is informational only and does not block the PR. Please review if the regression is expected or needs investigation.

View full benchmark results

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

⚠️ Performance Benchmark Regressions Detected

The following benchmarks show performance regression compared to the baseline:

See workflow summary for details

Note: This is informational only and does not block the PR. Please review if the regression is expected or needs investigation.

View full benchmark results

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

⚠️ Performance Benchmark Regressions Detected

The following benchmarks show performance regression compared to the baseline:

See workflow summary for details

Note: This is informational only and does not block the PR. Please review if the regression is expected or needs investigation.

View full benchmark results

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

⚠️ Performance Benchmark Regressions Detected

The following benchmarks show performance regression compared to the baseline:

See workflow summary for details

Note: This is informational only and does not block the PR. Please review if the regression is expected or needs investigation.

View full benchmark results

@sanity sanity added this pull request to the merge queue Jan 1, 2026
Merged via the queue into main with commit f509c74 Jan 1, 2026
10 checks passed
@sanity sanity deleted the fix-version-mismatch-log-format branch January 1, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants