Skip to content

Conversation

antoniotorresm
Copy link
Collaborator

No description provided.

*~

# Virtual environment
venv/
Copy link
Collaborator

@f-trivino f-trivino Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoniotorresm what about adding:

# Environments
.env
.venv
env/
venv/
ENV/
env.bak/
venv.bak/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we can also add entries for the doc venv:

docs/.venv
...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's take this opportunity to add:

/doc/_build
/doc/.venv

WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have /docs/_build and /docs/.venv, do we want /doc/* as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh.. you are right...
my bad.
no, we are fine with what it is already there.

Copy link
Collaborator

@f-trivino f-trivino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

*~

# Virtual environment
venv/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh.. you are right...
my bad.
no, we are fine with what it is already there.

@f-trivino f-trivino merged commit 389d369 into freeipa:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants