Enable ServiceProviderConfig GET request #7
Conversation
f-trivino
force-pushed
the
ServiceProviderConfig
branch
2 times, most recently
from
f854774 to
e981be7
Compare
|
I'm missing a requirement from the spec: "To enable seamless discovery of configurations, the service provider should, with the appropriate security considerations, make the authenticationSchemes attribute publicly accessible without prior authentication." The current implementation requires authentication, the code should make usage of the GET_IS_AUTHENTICATED_PREDICATE from django_scim app or custom csrf_exempt. |
There was a problem hiding this comment.
@f-trivino thanks for the PR. Please find my inline comments
f-trivino
force-pushed
the
ServiceProviderConfig
branch
2 times, most recently
from
4213674 to
de6a7c8
Compare
f-trivino
force-pushed
the
ServiceProviderConfig
branch
2 times, most recently
from
1a14c7a to
c9df679
Compare
There was a problem hiding this comment.
Hi @f-trivino
can you add a note in the README.me, just before If connecting from another system, update the ALLOWED_HOSTS:
Edit root/settings.py and update the 'NETLOC':'localhost' line with the name of the machine where the django server is running. This will appear as "location": "https://NETLOC/scim/v2/ServiceProviderConfig" in the output returned by a GET operation on /scim/v2/ServiceProviderConfig
f-trivino
force-pushed
the
ServiceProviderConfig
branch
from
c9df679 to
97a60cf
Compare
This commit enables the /ServiceProviderConfig endpoint for GET requests to view additional information about the ipa-tuura supported features. The endpoint is read only.
f-trivino
force-pushed
the
ServiceProviderConfig
branch
from
97a60cf to
f40ec1f
Compare
|
@flo-renaud thanks for the review, I addressed all your comments, I think the PR is ready now. |
|
@f-trivino thanks, ACK. |
This commit enables the /ServiceProviderConfig endpoint for GET requests to view additional information about the ipa-tuura supported features.
The endpoint is read only.